-1 Verified it works on the latest release iOS and Android, but I had a typo in the CSP string: https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c
Perhaps we could re-spin with this one fix and leave the vote end period the same (assuming everyone can still verify based on this one-character change)? On Wed, Mar 11, 2015 at 2:13 PM, Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote: > Voting +1 for this. Also did initial tests on Windows, seems to work > > • Verified signatures and hashes > • Verified tags > • Verified that app can be built and ran under windows, wp8 and android > platforms > • Verified release notes: > + added license header to config.xml > + added releasenotes.md > + removed version file, package.json can keep track of version > + Adding hooks to default app > + [CB-8597] First attempt at importing cordova-app-hello-world via > npm dependency > + Remove jasmine ref > + Tweak CSP string > + CB-8295 Add content-security-policy <meta> to template > + Remove target-density and height=device-height from <viewport> > + Remove self-closing slashes from <meta> since this isn't xhtml > > > -----Original Message----- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew > Grieve > Sent: Wednesday, March 11, 2015 7:16 AM > To: dev > Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release > > Note that this pulls in the addition of a content-security-policy <meta> > tag. > Please ensure that this doesn't break your platform when voting. > > On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.8.0 (0b55140d09) > > > > Upon a successful vote I will upload the archive to dist/ and publish > > it to NPM. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > > .md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > >
