Hi list, I have made a PR with some code cleanup and slight redesign for Medic, and I would like to please request a code review from folks in the community when it would be convenient for them! The PR is here: https://github.com/apache/cordova-medic/pull/37. For those interested in the details but not in reviewing the code, below are a list of changes and their justifications and a list of the specific incompatibilities with the previous medic code.
Code Changes and Reasons: 1. Putting private data into a private file: this was done to remove passwords from the repo 2. Splitting config into several files: this was done so that the config can be extended locally without affecting other installations that share code (i.e. Apache Infra Buildbot) 3. Removing PlatformTestBase and its child classes: this was done in favour of using build properties to modify build steps instead of hard platform code as much as possible 4. Using Buildbot Properties to pass parameters to builds: this was done so that medic doesn’t need to be reconfigured/restarted to run parametrized builds, which allows it to run in Apache Infrastructure and enables faster development 5. Adding step wrappers: this was done to reduce the probability of errors by setting sensible defaults for values that are easily forgotten 6. Removing categories from repo config: this was done to reduce code complexity for the checkout steps Incompatibilities: 1. The format of the `cordova-repos.json` file has changed; current files will need to simply be reformatted to match the new format, and they will work with the new medic code 2. Semantics of the `cordova-config.json` file have changed, and current setups will stop being able to control some of medic’s behaviour using their current files; namely, builders and schedulers are now configured in cordova.conf, and some platform settings have been removed (e.g. iOS keychain information) Kindly, Dmitry
