Agreed - everything looks good there. On Tue, Mar 24, 2015 at 8:43 PM, Andrew Grieve <agri...@chromium.org> wrote:
> that grep looks fine to me. > > On Tue, Mar 24, 2015 at 5:13 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > Leo, the whitelist plugin will only start being used after the next tools > > release. So timing should be fine. > > > > Andrew, I did a quick grep search for org.apache.cordova for both > whitelist > > plugins. Do any of these values need to be updated before releasing? > > > > cordova-plugin-whitelist > > grep -R "org.apache.cordova" * > > plugin.xml: <param name="android-package" > > value="org.apache.cordova.whitelist.WhitelistPlugin"/> > > plugin.xml: <source-file src="src/android/WhitelistPlugin.java" > > target-dir="src/org/apache/cordova/whitelist" /> > > src/android/WhitelistPlugin.java:package org.apache.cordova.whitelist; > > src/android/WhitelistPlugin.java:import org.apache.cordova.CordovaPlugin; > > src/android/WhitelistPlugin.java:import > org.apache.cordova.ConfigXmlParser; > > src/android/WhitelistPlugin.java:import org.apache.cordova.Whitelist; > > > > cordova-plugin-legacy-whitelist > > grep -R "org.apache.cordova" * > > plugin.xml: <param name="android-package" > > value="org.apache.cordova.whitelist.LegacyWhitelistPlugin"/> > > plugin.xml: <source-file > > src="src/android/LegacyWhitelistPlugin.java" > > target-dir="src/org/apache/cordova/whitelist" /> > > src/android/LegacyWhitelistPlugin.java:package > > org.apache.cordova.whitelist; > > src/android/LegacyWhitelistPlugin.java:import > > org.apache.cordova.CordovaInterface; > > src/android/LegacyWhitelistPlugin.java:import > > org.apache.cordova.CordovaPlugin; > > src/android/LegacyWhitelistPlugin.java:import > > org.apache.cordova.CordovaWebView; > > src/android/LegacyWhitelistPlugin.java:import > > org.apache.cordova.ConfigXmlParser; > > src/android/LegacyWhitelistPlugin.java:import > org.apache.cordova.Whitelist; > > > > On Tue, Mar 24, 2015 at 12:14 PM, Treggiari, Leo < > leo.treggi...@intel.com> > > wrote: > > > > > Is there a timing issue here? How can a plugin be published to npm > when > > > there is no tools release that will fetch from npm? > > > > > > Leo > > > > > > -----Original Message----- > > > From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of > > Ian > > > Clelland > > > Sent: Tuesday, March 24, 2015 6:42 AM > > > To: dev@cordova.apache.org > > > Subject: Re: [DISCUSS] Whitelist & Legacy Whitelist Plugins Release > > @1.0.0 > > > > > > We should definitely do that -- and I think we should release them > > > simultaneously with cordova-app-hello-world, since it now references > > > cordova-plugin-whitelist by that name (I had to install it from local > git > > > repo, but it still wasn't a perfectly smooth experience). > > > > > > On Mon, Mar 23, 2015 at 7:18 PM, Steven Gill <stevengil...@gmail.com> > > > wrote: > > > > > > > I'd like to start a vote thread for both plugins. I'm thinking they > > will > > > > only be published to npm and dist (no CPR). > > > > > > > > Thoughts? > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > >
