Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/194#discussion_r27298469 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -223,11 +211,13 @@ module.exports = { * @param {Boolean} determines if we are using the npm registry * @return {Promise.<Object>} Promised settings. */ -function initSettings() { +function initSettings(returnEmptySettings) { var settings = module.exports.settings; // check if settings already set - if(settings !== null) return Q(settings); + if(settings !== null) { --- End diff -- No it should not. Good catch, thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org