Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/171#discussion_r27481986
  
    --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
    @@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState) {
         public void restoreInstanceState(Bundle savedInstanceState) {
             initCallbackService = 
savedInstanceState.getString("callbackService");
         }
    +    
    +    private class ActivityResultHolder {
    +
    +        private int requestCode;
    +        private int resultCode;
    +        private Intent intent;
    +
    +        public ActivityResultHolder(int requestCode, int resultCode, 
Intent intent) {
    +            this.requestCode = requestCode;
    +            this.resultCode = resultCode;
    +            this.intent = intent;
    +        }
    +
    +        public int getRequestCode() {
    --- End diff --
    
    nit: no point in creating getters for a private class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to