You may have seen this before (deja-vu). If this is not the correct place for this, sorry that my focus is not on following a strict release process but rather releasing a good product.
Having read the proposed whitelist release notes, I have the following additional question: Based upon my understanding, which must be wrong! The 4.0.0 Android Release will require the cordova-plugin-whitelist in order to get a whitelist implemented correctly. Given its name (dash-style) it is only available as an node component. The is no released CLI that knows how to fetch from npm? Or does 4.3, even though I don't see it in the release notes? Even so, there are many previous CLI releases which will not work? It would be good for the release notes to explain the situation. Leo -----Original Message----- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, April 08, 2015 7:08 PM To: Andrew Grieve Cc: dev; Homer, Tony Subject: Re: [DISCUSS] Cordova-Android 4.0.0 Release CB-8684 is now merged and I've updated the targetSdk (and made a couple other changes). I'll start the release process in the morning as long as there no objections. On Tue, Apr 7, 2015 at 2:20 PM, Andrew Grieve <agri...@chromium.org> wrote: > I'll start on it once CB-8684 lands (Tony - assuming you'll have this done > shortly and would prefer it lands?) > > On Tue, Apr 7, 2015 at 1:33 PM, Jesse <purplecabb...@gmail.com> wrote: > >> Sweet! >> >> @purplecabbage >> risingj.com >> >> On Tue, Apr 7, 2015 at 8:35 AM, Andrew Grieve <agri...@chromium.org> >> wrote: >> >> > Let's do it! >> > >> > On Mon, Apr 6, 2015 at 7:33 PM, Joe Bowser <bows...@gmail.com> wrote: >> > >> > > So, I think we should put off the embedder's guide until after the >> > > release. A lot of it has changed, and since we're still technically >> > > obligated to support the 3.x release tree for six months, that should >> buy >> > > us some time to figure out how that is going to work. Getting >> Cordova to >> > > work with a vanilla Android Studio project is a non-trivial task. >> > > >> > > Given that everything else appears to be done, should we start voting >> on >> > an >> > > RC for this? What do people think? >> > > >> > > >> > > >> > > On Thu, Mar 19, 2015 at 10:31 AM Andrew Grieve <agri...@chromium.org> >> > > wrote: >> > > >> > > > Here's issues: >> > > > https://issues.apache.org/jira/browse/CB-8715 (docs) >> > > > https://issues.apache.org/jira/browse/CB-8716 (whitelist) >> > > > https://issues.apache.org/jira/browse/CB-8717 (write >> RELEASENOTES.md) >> > > > >> > > > On Tue, Mar 17, 2015 at 10:15 AM, Carlos Santana < >> csantan...@gmail.com >> > > >> > > > wrote: >> > > > >> > > > > I would say let's start RC testing and voting, But not pin the >> > version >> > > in >> > > > > Cordova CLI until the tasks that Andrew mentioned are done. >> > > > > Andrew can you create the JIRA Items for the tasks that need to be >> > > done. >> > > > I >> > > > > thought there was a discussion about creating JIRA Items to help >> > track >> > > > and >> > > > > know what's left for release something. >> > > > > >> > > > > - upgrade guide, >> > > > > - publishing whitelist plugins, >> > > > > - and making it so that the default project template includes >> <plugin >> > > > > name="cordova-plugin-whitelist" />) >> > > > > >> > > > > >> > > > > On Mon, Mar 16, 2015 at 11:21 PM, Ian Clelland < >> > iclell...@chromium.org >> > > > >> > > > > wrote: >> > > > > >> > > > > > We'll probably need at least an RC for the whitelist plugin, if >> > not a >> > > > > vote, >> > > > > > to be able to vote on this. >> > > > > > >> > > > > > Or can we just include instructions like "Use >> > > > > > cordova-plugin-whitelist@f70b1bc for testing" while we start >> the >> > > > > official >> > > > > > release process for the plugins? >> > > > > > >> > > > > > On Mon, Mar 16, 2015 at 11:17 PM, Ian Clelland < >> > > iclell...@chromium.org >> > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > +1 -- Let's get this out the door :) >> > > > > > > I'll see what I can get done to move it in that direction. >> > > > > > > >> > > > > > > On Mon, Mar 16, 2015 at 7:51 PM, Andrew Grieve < >> > > agri...@chromium.org >> > > > > >> > > > > > > wrote: >> > > > > > > >> > > > > > >> Everything's ready afaik (minus upgrade guide, publishing >> > > whitelist >> > > > > > >> plugins, and making it so that the default project template >> > > includes >> > > > > > >> <plugin name="cordova-plugin-whitelist" />). Maybe let's do >> a RC >> > > > while >> > > > > > we >> > > > > > >> wait on these things being finished up? >> > > > > > >> >> > > > > > >> If anyone wants to take on any of these tasks, that would be >> > > > awesome. >> > > > > > >> >> > > > > > >> On Mon, Mar 16, 2015 at 4:57 PM, Shazron <shaz...@gmail.com> >> > > wrote: >> > > > > > >> >> > > > > > >> > +1 for vote thread, let's get this thing out so people >> (that >> > are >> > > > not >> > > > > > >> > us) can test... >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > On Mon, Mar 16, 2015 at 1:41 PM, Joe Bowser < >> > bows...@gmail.com> >> > > > > > wrote: >> > > > > > >> > > OK, this is a three month old thread, and we're waiting >> on a >> > > > > > >> discussion >> > > > > > >> > > before we release something? I really think we should go >> to >> > a >> > > > vote >> > > > > > >> thread >> > > > > > >> > > now that we have a legacy whitelist plugin and a new >> style >> > > > > whitelist >> > > > > > >> > > plugin. We shouldn't keep constantly delaying this >> release >> > > > > because >> > > > > > of >> > > > > > >> > > what's happening on other platforms, especially since we >> > > already >> > > > > > >> > pluginized >> > > > > > >> > > the whitelist. >> > > > > > >> > > >> > > > > > >> > > Can we please release soon? >> > > > > > >> > > >> > > > > > >> > > On Thu, Mar 12, 2015 at 2:20 PM Nikhil Khandelwal < >> > > > > > >> > nikhi...@microsoft.com> >> > > > > > >> > > wrote: >> > > > > > >> > > >> > > > > > >> > >> I know we discussed a couple of approaches implementing >> the >> > > > > default >> > > > > > >> > >> whitelist policy for Android/iOS - either every app >> would >> > be >> > > > > > >> required to >> > > > > > >> > >> include the whitelist plugin or have it have smart >> defaults >> > > in >> > > > > the >> > > > > > >> > platform >> > > > > > >> > >> implementation and the plugin being able to override >> them. >> > > > > > >> > >> >> > > > > > >> > >> I don’t think that thread closed with any conclusions. >> > > > > > >> > >> >> > > > > > >> > >> Thanks, >> > > > > > >> > >> Nikhil >> > > > > > >> > >> >> > > > > > >> > >> >> > > > > > >> > >> -----Original Message----- >> > > > > > >> > >> From: Joe Bowser [mailto:bows...@gmail.com] >> > > > > > >> > >> Sent: Thursday, March 12, 2015 11:23 AM >> > > > > > >> > >> To: dev >> > > > > > >> > >> Subject: Re: [DISCUSS] Cordova-Android 4.0.0 Release >> > > > > > >> > >> >> > > > > > >> > >> OK, so right now it's just docs? How soon can we get a >> VOTE >> > > > > thread >> > > > > > >> > started >> > > > > > >> > >> for 4.0.0? >> > > > > > >> > >> >> > > > > > >> > >> On Wed, Mar 4, 2015 at 10:47 AM Andrew Grieve < >> > > > > > agri...@chromium.org> >> > > > > > >> > >> wrote: >> > > > > > >> > >> >> > > > > > >> > >> > mobilespec is now working again... Took longer than I >> > would >> > > > > have >> > > > > > >> > >> > liked, but did you know that on Android FileReader >> > triggers >> > > > > > >> > >> > shouldInterceptRequest() with Blob URLs!? >> > > > > > >> > >> > >> > > > > > >> > >> > Separate thread is already happening re: whitelists, >> so >> > > once >> > > > > > that's >> > > > > > >> > >> > figured out, it's just docs afaict. >> > > > > > >> > >> > >> > > > > > >> > >> > On Mon, Mar 2, 2015 at 10:52 PM, Ian Clelland < >> > > > > > >> iclell...@chromium.org >> > > > > > >> > > >> > > > > > >> > >> > wrote: >> > > > > > >> > >> > >> > > > > > >> > >> > > On Mon, Mar 2, 2015 at 6:00 PM, Jesse < >> > > > > purplecabb...@gmail.com >> > > > > > > >> > > > > > >> > wrote: >> > > > > > >> > >> > > >> > > > > > >> > >> > > > We should start a new whitelist plugin related >> > thread. >> > > > > > >> > >> > > > >> > > > > > >> > >> > > > Why is a plugin blocking a release? Default (aka >> > > > > no-plugin) >> > > > > > >> > >> > > > behavior should be to allow all network requests >> > > > shouldn't >> > > > > > it? >> > > > > > >> > >> > > >> > > > > > >> > >> > > >> > > > > > >> > >> > > Well, that just might be a blacklist then :) >> > > > > > >> > >> > > >> > > > > > >> > >> > > >> > > > > > >> > >> > > > This thread is a >> > > > > > >> > >> > > > month long, and not the first discussion of 4.0.0 >> for >> > > > > > Android. >> > > > > > >> > >> > > > >> > > > > > >> > >> > > >> > > > > > >> > >> > > Seriously, though -- the whitelist discussion is >> much >> > > > longer >> > > > > > than >> > > > > > >> > >> > > that, >> > > > > > >> > >> > and >> > > > > > >> > >> > > this isn't the first time that the default >> > > > no-network-access >> > > > > > >> policy >> > > > > > >> > >> > > has been brought up: >> > > > > > >> > >> > > >> > > > > > >> > >> > > (Here's the first question, from *July*: >> > > > > > >> > >> > > http://markmail.org/message/t4vj4saisem2mcgw >> > > > > > >> > >> > > Here's where I mentioned what the implemented policy >> > was: >> > > > > > >> > >> > > http://markmail.org/message/s4necfnh4hnblpjm >> > > > > > >> > >> > > And in another discussion: >> > > > > > >> > >> > > http://markmail.org/message/ap7syhqysizmsvrz) >> > > > > > >> > >> > > >> > > > > > >> > >> > > If we want to reconsider that decision, then we >> should >> > > > > > certainly >> > > > > > >> do >> > > > > > >> > >> > > so before we cut a release. I think it would be a >> real >> > > > > problem >> > > > > > to >> > > > > > >> > >> > > change it afterwards, so let's get it right. >> > > > > > >> > >> > > >> > > > > > >> > >> > > Also, it's not the plugin itself that's blocking the >> > > > release, >> > > > > > >> it's >> > > > > > >> > >> > > us making sure that we've implemented the core hooks >> > > > > correctly >> > > > > > so >> > > > > > >> > >> > > that the plugin can actually do its job, and that >> > people >> > > > who >> > > > > > >> don't >> > > > > > >> > >> > > want that particular plugin can make a better one. >> > > > > > >> > >> > > >> > > > > > >> > >> > > (It is also an issue that a plugin, required for >> > > > > > cordova-android >> > > > > > >> > >> > > 4.0.0, breaks apps which are also building for >> > > cordova-ios >> > > > > > 3.8.0. >> > > > > > >> > >> > > I'll take a >> > > > > > >> > >> > look >> > > > > > >> > >> > > at that, and either remove the ios-native portions >> of >> > the >> > > > > > >> whitelist >> > > > > > >> > >> > plugin, >> > > > > > >> > >> > > or neuter it so that it doesn't interfere with an >> ios >> > app >> > > > if >> > > > > > it's >> > > > > > >> > >> > > not on the unplug-whitelist branch of that repo.) >> > > > > > >> > >> > > >> > > > > > >> > >> > > Ian >> > > > > > >> > >> > > >> > > > > > >> > >> > > >> > > > > > >> > >> > > > @purplecabbage >> > > > > > >> > >> > > > risingj.com >> > > > > > >> > >> > > > >> > > > > > >> > >> > > > On Mon, Mar 2, 2015 at 2:02 PM, Shazron < >> > > > shaz...@gmail.com >> > > > > > >> > > > > > >> > wrote: >> > > > > > >> > >> > > > >> > > > > > >> > >> > > > > legacy-whitelist-plugin should be fixed so that >> it >> > > > > compiles >> > > > > > >> on >> > > > > > >> > >> > > > > cordova-ios@3.8.0. It shouldn't be a problem to >> > fix >> > > > this >> > > > > > at >> > > > > > >> > >> > > > > compile >> > > > > > >> > >> > or >> > > > > > >> > >> > > > > run-time (whichever is applicable here related >> to >> > the >> > > > > > compile >> > > > > > >> > >> > > > > error) >> > > > > > >> > >> > > > > >> > > > > > >> > >> > > > > On Mon, Mar 2, 2015 at 1:47 PM, Darryl Pogue >> > > > > > >> > >> > > > > <dvpdin...@gmail.com> >> > > > > > >> > >> > > > wrote: >> > > > > > >> > >> > > > > > On 2 March 2015 at 13:37, Joe Bowser < >> > > > > bows...@gmail.com> >> > > > > > >> > wrote: >> > > > > > >> > >> > > > > >> So, right now the whitelist changes are >> what's >> > > > holding >> > > > > > up >> > > > > > >> the >> > > > > > >> > >> > 4.0.0 >> > > > > > >> > >> > > > > release >> > > > > > >> > >> > > > > >> now? Is this really the only thing that's >> > holding >> > > > up >> > > > > > this >> > > > > > >> > >> > release? >> > > > > > >> > >> > > > > >> >> > > > > > >> > >> > > > > >> On Wed Feb 25 2015 at 1:18:26 PM Andrew >> Grieve < >> > > > > > >> > >> > > agri...@chromium.org> >> > > > > > >> > >> > > > > wrote: >> > > > > > >> > >> > > > > >> >> > > > > > >> > >> > > > > >>> I think we'll also need to finish with the >> > > > whitelist >> > > > > > >> changes >> > > > > > >> > >> > > > > >>> & >> > > > > > >> > >> > have >> > > > > > >> > >> > > > > both >> > > > > > >> > >> > > > > >>> the legacy and new-way whitelist plugins >> > released >> > > > > > before >> > > > > > >> we >> > > > > > >> > >> > > > > >>> can >> > > > > > >> > >> > do >> > > > > > >> > >> > > a >> > > > > > >> > >> > > > > 4.0.0 >> > > > > > >> > >> > > > > >>> release (otherwise you wouldn't be able to >> > write >> > > an >> > > > > app >> > > > > > >> that >> > > > > > >> > >> > > > > >>> hits >> > > > > > >> > >> > > the >> > > > > > >> > >> > > > > >>> network) >> > > > > > >> > >> > > > > >>> >> > > > > > >> > >> > > > > > >> > > > > > >> > >> > > > > > Just FYI, the whitelist stuff is proving to >> be a >> > > bit >> > > > > of a >> > > > > > >> pain >> > > > > > >> > >> > point. >> > > > > > >> > >> > > > > > I'm using cordova-android@master, and need to >> > > > install >> > > > > > the >> > > > > > >> > >> > > > > > legacy-whitelist plugin in order to make >> network >> > > > > > requests. >> > > > > > >> > >> > > > > > Once the plugin is installed, everything >> seems to >> > > > work. >> > > > > > >> > >> > > > > > >> > > > > > >> > >> > > > > > The problem is that the legacy-whitelist >> plugin >> > > > > generates >> > > > > > >> > >> > > > > > compile errors with cordova-ios@3.8.0, so >> now I >> > > > can't >> > > > > > just >> > > > > > >> > run >> > > > > > >> > >> > > > > > `cordova build`, I need to split the >> platforms up >> > > and >> > > > > > >> > >> > > > > > install/uninstall the plugin in between. If >> > someone >> > > > > > makes a >> > > > > > >> > >> > > > > > dev build for Android and forgets the plugin, >> it >> > > will >> > > > > > >> appear >> > > > > > >> > >> > > > > > to build successfully but not actually >> function >> > > > > properly >> > > > > > >> due >> > > > > > >> > to >> > > > > > >> > >> the whitelist. >> > > > > > >> > >> > > > > > >> > > > > > >> > >> > > > > > I know, this is all pre-release, so pain is >> > > somewhat >> > > > > > >> expected >> > > > > > >> > >> > > > > > right now. I'm worried about the case where >> > > > > > >> > >> > > > > > cordova-android@4.0.0 is released and >> > > > > cordova-ios@3.8.0 >> > > > > > is >> > > > > > >> > >> > > > > > still current, and how people >> > > > > > >> > >> > can >> > > > > > >> > >> > > > > > avoid whitelist breakage there. >> > > > > > >> > >> > > > > > >> > > > > > >> > >> > > > > > >> > > > > > >> ------------------------------------------------------------ >> > > > > > >> > >> > --------- >> > > > > > >> > >> > > > > > To unsubscribe, e-mail: >> > > > > > dev-unsubscr...@cordova.apache.org >> > > > > > >> > >> > > > > > For additional commands, e-mail: >> > > > > > >> dev-h...@cordova.apache.org >> > > > > > >> > >> > > > > > >> > > > > > >> > >> > > > > >> > > > > > >> > >> > > > > >> > > > > > ------------------------------------------------------------ >> > > > > > >> > >> > --------- >> > > > > > >> > >> > > > > To unsubscribe, e-mail: >> > > > > dev-unsubscr...@cordova.apache.org >> > > > > > >> > >> > > > > For additional commands, e-mail: >> > > > > > dev-h...@cordova.apache.org >> > > > > > >> > >> > > > > >> > > > > > >> > >> > > > > >> > > > > > >> > >> > > > >> > > > > > >> > >> > > >> > > > > > >> > >> > >> > > > > > >> > >> >> > > > > > >> > >> > > > > > >> > >> > > > > >> --------------------------------------------------------------------- >> > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > > > > >> > For additional commands, e-mail: >> dev-h...@cordova.apache.org >> > > > > > >> > >> > > > > > >> > >> > > > > > >> >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Carlos Santana >> > > > > <csantan...@gmail.com> >> > > > > >> > > > >> > > >> > >> > >
