Github user shazron commented on the pull request:

    
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94391292
  
    Looks good to me. I'll pull it in in the morning, but this block could have 
been tightened up a bit: 
https://github.com/shazron/CB-7734/blob/882882c5fd03dd0a343e8ee8c85a362d40c82d48/platforms/ios/CB-7734/Plugins/cordova-plugin-dialogs/CDVNotification.m#L50-L62
  but it's no biggie.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to