Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/175#discussion_r29046516
  
    --- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
    @@ -115,8 +116,24 @@ public void onCreate(Bundle savedInstanceState) {
                 
getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
                         WindowManager.LayoutParams.FLAG_FULLSCREEN);
             } else if (preferences.getBoolean("Fullscreen", false)) {
    -            
getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
    +
    +            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT)
    +            {
    +                setSystemUiVisibilityMode(getWindow());
    +                
getWindow().getDecorView().setOnSystemUiVisibilityChangeListener(new 
View.OnSystemUiVisibilityChangeListener() {
    --- End diff --
    
    I don't think this listener should be necessary. According to:
    https://developer.android.com/training/system-ui/immersive.html
    
    setting IMMERSIVE_STICKY should take care of re-entering fullscreen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to