Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/127#discussion_r29300643
--- Diff: www/csp-incl.js ---
@@ -49,7 +49,13 @@ if (!window._disableCSP) {
switch (PLAT) {
case 'android':
case 'ios':
- cspMetaContent = 'default-src \'self\'
https://ssl.gstatic.com/accessibility/javascript/android/; connect-src \'self\'
http://cordova-filetransfer.jitsu.com;frame-src \'self\' data: gap:; img-src
\'self\' data:; style-src \'self\' \'unsafe-inline\'';
+ case 'windows8':
+ cspMetaContent = 'default-src \'self\'
https://ssl.gstatic.com/accessibility/javascript/android/;' +
+ ' connect-src \'self\'
http://cordova-filetransfer.jitsu.com;' +
+ ' media-src \'self\'
http://cordova.apache.org/downloads/;' +
+ ' frame-src \'self\' data: gap:;' +
+ ' img-src \'self\' data:;' +
+ ' style-src \'self\' \'unsafe-inline\'';
--- End diff --
Even though the fact that this fixes things on Windows is actually really
valuable, the formatting is the best thing about this change. Small nit: might
be better to use double-quotes for the strings so you won't have to escape as
much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
