I agree we should keep it, at least for the time being. There is code in coho that manipulates all the versions in different branches when we do releases, changing it would mean we need to update all of that coho logic also. Granted, coho releases would be simpler without the suffix, however, I don't think it is currently worth the change.
@purplecabbage risingj.com On Thu, May 14, 2015 at 10:35 AM, Nikhil Khandelwal <[email protected]> wrote: > Now that we know how to fix the plugin to work with 'dev' versions of > platforms, we could keep the 'dev' suffix. It's somewhat useful for anyone > using our 'master' branch (I'm hoping its mostly the dev team) and adding > the platform and have the dev prefix listed here: > > λ cordova platform ls > Installed platforms: android 4.1.0-dev, ios 3.8.0, windows 4.0.0-dev, wp8 > Available platforms: amazon-fireos, blackberry10, browser, firefoxos, > windows8 > > Thanks, > Nikhil > > > -----Original Message----- > From: Jesse [mailto:[email protected]] > Sent: Wednesday, May 13, 2015 4:39 PM > To: [email protected] > Subject: Re: [DISCUSS] Dropping the -dev suffix > > So back to the initial discussion, should we keep our -dev suffixes? > If so we need to be sure to use engine tags like '>=4.0' or if you > specifically want to force a specific min patch, and still allow the dev > suffix, you can do '>=4.0.0--' > > And of course this should be documented. > > > @purplecabbage > risingj.com > > On Wed, May 13, 2015 at 4:21 PM, Jesse <[email protected]> wrote: > > > Yes, I just verified the same. > > > > Changing the plugin.xml engine to : > > cordova-wp8 >=4.0.0-- will allow install for both [email protected] and > > [email protected] > > > > @purplecabbage > > risingj.com > > > > On Wed, May 13, 2015 at 4:18 PM, Tim Barham <[email protected]> > > wrote: > > > >> No, you were correct - any sort of pre-release identifier makes the > >> version less than the version without the pre-release identifier > >> (since it signifies a pre-release). > >> > >> Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and > >> '4.0.0-iwishiwasarealreease' are all < 4.0.0. > >> > >> It seems to me the problem is with the plugin since it requires > >> cordova-wp8 >=4.0.0, and there is no cordova-wp8 release (or yet to > >> be released version on github) that satisfies that requirement. > >> > >> ________________________________________ > >> From: So, Byoungro <[email protected]> > >> Sent: Thursday, May 14, 2015 3:39 AM > >> To: [email protected] > >> Subject: RE: [DISCUSS] Dropping the -dev suffix > >> > >> Sorry, I got the other way around. :) 4.0.0-dev is > 4.0.0. > >> > >> Byoungro So > >> SSG / DPD / Mobile Computing and Compilers Intel Corporation > >> > >> -----Original Message----- > >> From: So, Byoungro > >> Sent: Wednesday, May 13, 2015 10:37 AM > >> To: [email protected] > >> Subject: RE: [DISCUSS] Dropping the -dev suffix > >> > >> Semver should be able to understand '4.0.0-dev' as the valid version > >> string. > >> There could be some other requirement problems, like <=, >. > >> For example, 4.0.0-dev is < 4.0.0. > >> So, if the requirement is >=4.0.0, then the version string '4.0.0-dev' > >> will fail to satisfy the requirement. > >> > >> Byoungro So > >> SSG / DPD / Mobile Computing and Compilers Intel Corporation > >> > >> -----Original Message----- > >> From: Steven Gill [mailto:[email protected]] > >> Sent: Wednesday, May 13, 2015 10:21 AM > >> To: [email protected] > >> Subject: [DISCUSS] Dropping the -dev suffix > >> > >> Recently, a issue (CB-9021) popped up where mobile spec was failing > >> because the semver check failed on a platform due to `-dev` being in > >> the version and not valid. > >> > >> I think we should remove -dev from our versions. Right now, after we > >> do a release, we add -dev to show that the repo is in development and > >> hasn't been released. I think we can accomplish the same by just > >> bumping the version (minor?) in the package.json and just know it > >> isn't released by seeing what is published on npm. > >> > >> Thoughts? > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
