Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31061078
--- Diff: bin/lib/check_reqs.js ---
@@ -196,20 +208,22 @@ module.exports.check_android = function() {
process.env['ANDROID_HOME'] = grandParentDir;
hasAndroidHome = true;
} else {
- throw new Error('ANDROID_HOME is not set and no "tools"
directory found at ' + parentDir);
+ throw new Error('Failed to find \'ANDROID_HOME\'
environment variable. Try setting setting it manually.\n' +
+ 'Detected \'android\' command at ' + parentDir + ' but
no \'tools\' directory found near.\n' +
+ 'Try reinstall Android SDK or update your PATH to
include path to valid SDK directory.');
}
}
if (hasAndroidHome && !adbInPath) {
process.env['PATH'] += path.delimiter +
path.join(process.env['ANDROID_HOME'], 'platform-tools');
}
if (!process.env['ANDROID_HOME']) {
- throw new Error('ANDROID_HOME is not set and "android" command
not in your PATH. You must fulfill at least one of these conditions.');
+ throw new Error('Failed to find \'ANDROID_HOME\' environment
variable. Try setting setting it manually.\n' +
+ 'Failed to find \'android\' command in your \'PATH\'. Try
update your \'PATH\' to include path to valid SDK directory.');
}
if (!fs.existsSync(process.env['ANDROID_HOME'])) {
- throw new Error('ANDROID_HOME is set to a non-existant path: '
+ process.env['ANDROID_HOME']);
+ throw new Error('\'ANDROID_HOME\' environment variable is
leads to non-existant path: ' + process.env['ANDROID_HOME'] +
--- End diff --
Typo - 'existent' (I know - not new code, but good to fix while you're here)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
