I vote +1:
* Ran 'coho verify-tags', and it passed
* Ran 'coho audit-license-headers', and got some files reported as 
non-compliant, but I’ve been convinced by Nikhil Khandelwal and Tim Barham that 
they should be in ratExcludes
* Installed the code and ran NPM tests using Medic:
        * OSX: 
http://cdv-ms-buildbot.cloudapp.net/builders/cordova-tools-release-osx/builds/8
        * Windows: 
http://cdv-ms-buildbot.cloudapp.net/builders/cordova-tools-release-win/builds/8
* Observed some failures on Windows, but it seems that they’re expected

Kindly,
Dmitry

> On May 29, 2015, at 2:07 PM, Steven Gill <stevengil...@gmail.com> wrote:
> 
> bump
> 
> On Wed, May 27, 2015 at 4:58 PM, Steven Gill <stevengil...@gmail.com> wrote:
> 
>> Please review and vote on this Tools Release
>> by replying to this email (and keep discussion on the DISCUSS thread)
>> 
>> Release issue: https://issues.apache.org/jira/browse/CB-9087
>> 
>> Both tools have been published to 
>> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9087/
>> 
>> The packages were published from their corresponding git tags:
>> 
>>    cordova-js: 4.0.0 (706c4a8936)
>>    cordova-lib: 5.1.0 (d57d70bbc9)
>>    cordova-plugman: 0.23.2 (d02fcbc8d1)
>>    cordova-cli: 5.1.0 (98fece9a55)
>> 
>> Upon a successful vote I will upload the archives to dist/, publish them to 
>> NPM, and post the corresponding blog post.
>> 
>> Voting guidelines: 
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>> 
>> Voting will go on for a minimum of 48 hours.
>> 
>> I vote +1:
>> * Ran coho audit-license-headers over the relevant repos
>> * Ran unit tests and saw that they were all building
>> * Build a cordova project for ios and android and added a plugin.
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to