[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

[ogoguel]

Github user ogoguel commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/219#discussion_r31519205
  
    --- Diff: cordova-lib/package.json ---
    @@ -42,7 +42,7 @@
         "underscore": "1.7.0",
         "unorm": "1.3.3",
         "valid-identifier": "0.0.1",
    -    "xcode": "0.6.7"
    +    "xcode": 
"https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d";
    --- End diff --
    
    A pull request has been sent to node-xcode (
    https://github.com/alunny/node-xcode/pull/47), but in the meantime, I was
    using a tarball reference to have a working version
    
    Actually, my pull request has just been merged into node-xcode master, but
    the version not yet updated into the npm repository : what should I put
    into the package.json in the meantime ?
    https://github.com/alunny/node-xcode.git ?
    
    Thanks for your pointer
    Cheers
    Olivier
    
    2015-06-02 11:38 GMT+02:00 Georgi Alexandrov <notificati...@github.com>:
    
    > In cordova-lib/package.json
    > <https://github.com/apache/cordova-lib/pull/219#discussion_r31506402>:
    >
    > > @@ -42,7 +42,7 @@
    > >      "underscore": "1.7.0",
    > >      "unorm": "1.3.3",
    > >      "valid-identifier": "0.0.1",
    > > -    "xcode": "0.6.7"
    > > +    "xcode": 
"https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d";
    >
    > You should create PR with your changes to node-xcode
    > <https://github.com/alunny/node-xcode> instead of using tarball dependency
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cordova-lib/pull/219/files#r31506402>.
    >
    
    
    
    -- 
    ıllıllı ɹǝ!ʌ!ןo ıllıllı



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org