Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/144#discussion_r31713805
  
    --- Diff: bin/templates/scripts/cordova/lib/build.js ---
    @@ -87,6 +87,13 @@ module.exports.run = function (argv) {
             }
             return Q.nfcall(fs.writeFile, path.join(__dirname, '..', 
'build-extras.xcconfig'), extraConfig, 'utf-8');
         }).then(function () {
    +        // Ensure platform scripts are executable as the platform could be 
added on non-OSX environment
    +        shell.find(projectPath).filter(function (file) {
    --- End diff --
    
    Should we check `cordova` folder only? (projectPath/cordova). My concern is 
that there could be too many files in other folders like `www` so this could be 
slow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to