Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/244#discussion_r32075367
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -364,6 +364,28 @@ function fetchPlugin(plugin, client, useNpmRegistry) {
         });
     }
     
    +function processPluginVersion(plugin) {
    +    // If plugin includes a version that is a caret range, the ancient 
version of npm we're using won't now how to
    +    // handle it. So we'll use our current version of semver to turn it 
into a usable range.
    +
    +    var parts = plugin.split('@');
    +    var version = parts[1];
    +
    +    if (!version || version.charAt(0) !== '^') {
    +        return plugin;
    +    }
    +
    +    var validRange = semver.validRange(version, /* loose */ true);
    +    if (!validRange) {
    +        return plugin;
    +    }
    +
    +    console.log('Returning processed plugin range: ' + parts[0] + '@"' + 
validRange + '"');
    --- End diff --
    
    I would change console.log to events.emit('log', MSG) or ' 
events.emit('verbose', MSG)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to