Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/247#discussion_r32458351
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -168,10 +168,19 @@ module.exports = function plugin(command, targets,
opts) {
})
.then(function(dir) {
// Validate top-level required variables
- var pluginVariables =
pluginInfoProvider.get(dir).getPreferences(),
- missingVariables =
pluginVariables.filter(function (v) {
+ var pluginVariables =
pluginInfoProvider.get(dir).getPreferences();
+ var requiredVariables = [];
+ for(var i in pluginVariables)
+ {
+ var v = pluginVariables[i];
+ // discard variables with default value
+ if (!v.default)
--- End diff --
When I test this adding a plugin that requires variables (for example,
`com.phonegap.plugins.facebookconnect`) and I don't specify any, this line
throws (`v` is `null`). The logic here doesn't seem to coincide with the actual
value returned by `getPreferences()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
