Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879192
--- Diff: src/android/CameraLauncher.java ---
@@ -124,16 +127,9 @@ public boolean execute(String action, JSONArray args,
CallbackContext callbackCo
this.mediaType = PICTURE;
this.mQuality = 80;
--- End diff --
I would get rid of all of these defaults here. I like your use of `optInt`,
and passing in defaults; would suggest just eliminating the forced defaults
above and go with the single line initialization in the method.
FWIW, here's how I ported this to my local copy:
if (action.equals("takePicture")) {
int srcType = args.optInt(2, CAMERA);
int destType = args.optInt(1, FILE_URI);
// Process the rest of the configuration arguments
processConfiguration(args);
...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
