Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/246#discussion_r33290055 --- Diff: cordova-lib/spec-cordova/helpers.js --- @@ -17,12 +17,23 @@ under the License. */ -var path = require('path'), - fs = require('fs'), - shell = require('shelljs'), - os = require('os'); +var path = require('path'), + fs = require('fs'), + shell = require('shelljs'), + os = require('os'), + ConfigParser = require('../src/configparser/ConfigParser'); -module.exports.tmpDir = function(subdir) { +// Just use Android everywhere; we're mocking out any calls to the `android` binary. +module.exports.testPlatform = 'android'; + +function getConfigPath(dir) { + if (dir.indexOf('config.xml') !== dir.length - 10) { --- End diff -- I see what you're doing there. I think you should use underscore (which we already include) to do that: http://aganov.github.io/underscore-strings/docs/underscore.strings.html#section-10
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org