Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482012
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
var id = args[0];
var thisM = Media.get(id);
- var normalizedSrc = thisM.src.replace(/\//g, '\\');
+ var success = function () {
+ Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_STOPPED);
+ win();
+ };
+
+ var error = function (reason) {
+ Media.onStatus(id, Media.MEDIA_ERROR, reason);
+ lose(reason);
+ };
+
+ var fsTypes = {
+ PERSISTENT: 'PERSISTENT',
+ TEMPORARY: 'TEMPORARY'
+ };
+ var fsType;
+
+ var normalizedSrc = thisM.src;
+ normalizedSrc = setTemporaryFsByDefault(normalizedSrc);
+
+ if (normalizedSrc.indexOf('ms-appdata:///local/') === 0) {
--- End diff --
Is this component going to allow for interoperable code among platforms? I
just want to ensure that the developer isn't expected to utter
"ms-appdata:///local/" - instead they're getting that from some service (or
we're converting into that from some other argument) so that the developer can
just write "persistent" or "temporary" and it saves.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
