Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130435 --- Diff: src/windows/CameraProxy.js --- @@ -696,21 +696,22 @@ function takePictureFromCameraWindows(successCallback, errorCallback, args) { // decide which max pixels should be supported by targetWidth or targetHeight. var maxRes = null; var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution; + var totalPixels = targetWidth * targetHeight; switch (true) { - case (targetWidth >= 1280 || targetHeight >= 960) : - cameraCaptureUI.photoSettings.maxResolution = UIMaxRes.large3M; + case (totalPixels <= 320 * 240): + cameraCaptureUI.photoSettings.maxResolution = UIMaxRes.verySmallQvga; break; - case (targetWidth >= 1024 || targetHeight >= 768) : - maxRes = UIMaxRes.mediumXga; + case (totalPixels <= 640 * 480): + maxRes = UIMaxRes.smallVga; break; - case (targetWidth >= 800 || targetHeight >= 600) : + case (totalPixels <= 1024 * 768): maxRes = UIMaxRes.mediumXga; break; - case (targetWidth >= 640 || targetHeight >= 480) : - maxRes = UIMaxRes.smallVga; + case (totalPixels <= 3 * 1000 * 1000): + maxRes = UIMaxRes.large3M; break; - case (targetWidth >= 320 || targetHeight >= 240) : - maxRes = UIMaxRes.verySmallQvga; + case (totalPixels <= 5 * 1000 * 1000): + maxRes = UIMaxRes.veryLarge5M; break; default : maxRes = UIMaxRes.highestAvailable; --- End diff -- Add `break;` after this line.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org