GitHub user idpaterson opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/55
CB-9449 - Allow a blank string for dialog titles and messages.
Currently there is no way to create a dialog in the Cordova Dialogs plugin
without a title. Providing an empty string as the title for any of alert,
confirm, or prompt results in a non-localized default title. This makes it
impossible to show message-only dialogs on platforms that support such a thing,
like iOS. Currently, all dialogs must have a title and additionally prompts
must have a message, whether they are provided by the developer or forced by
the plugin.
### No workarounds
There are no known workarounds. One that came to mind was passing a space
character `navigator.notification.alert('message', null, ' ');` but on iOS this
results in a blank space for the title at the top of the alert. Sending an
object that will evaluate to true but return a blank string when stringified
causes the app to crash `navigator.notification.alert('message', null,
{toString: function() { return ''; }});`
### Solution
Rather than testing whether title is falsy to set the default, test whether
it is a string, regardless of whether it is a falsy empty string.
### Breaking change?
Requiring the title to be a string prevents numeric and other values from
being used, while previously they were passed through to the native plugin.
This is a *good thing* because sending anything other than a string causes the
plugin to crash the app (at least on iOS), so despite being more restrictive
about the data type, I do not consider it a breaking change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Newstex/cordova-plugin-dialogs
pull-requests/blank-titles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 03444fcfe204d0576313702b5fe5ac2c6732798d
Author: ipaterson <[email protected]>
Date: 2015-08-04T19:33:40Z
Allow a blank string for dialog titles and messages.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
