+1 - verify signatures - verify tags - recreated archive and compare contents - review commits for cordoba-serve - tested `cordova serve` with ios, android, and browser
On Wed, Aug 26, 2015 at 2:48 PM Jesse <purplecabb...@gmail.com> wrote: > +1 > > - verified signatures > - ran > cordova run browser > - verified `cordova serve` command works > > > My team is hiring! > @purplecabbage > risingj.com > > On Tue, Aug 25, 2015 at 8:08 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > I vote +1: > > > > * Verified tags > > * Verified signatures > > * Manually verified `cordova serve` command works correct for android, > ios > > and windows platforms > > * Verified CB-9546 - cordova-serve.servePlatform() correctly returns > > projectRoot > > > > Sergey Grebnov > > > > -----Original Message----- > > From: Tim Barham [mailto:tim.bar...@microsoft.com] > > Sent: Monday, August 24, 2015 4:24 PM > > To: 'dev@cordova.apache.org' <dev@cordova.apache.org> > > Subject: [VOTE] 0.1.3 cordova-serve release > > > > Please review and vote on this 0.1.3 release of cordova-serve by replying > > to this email (and keep discussion on the DISCUSS thread). > > > > Release issue: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9547&data=01%7c01%7cv-segreb%40microsoft.com%7c6d5b2849a8814248ccb308d2ac873ef4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cBsLQ3OikTTOVilEA3CU2AK5Yljn%2b%2bpGdtRiHruCvmM%3d > > > > The archive has been published to dist/dev: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-9547&data=01%7c01%7cv-segreb%40microsoft.com%7c6d5b2849a8814248ccb308d2ac873ef4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Epln%2fsBX5UMtxF%2fkzoeGOdoclqZJ10NUkmoBTVjCxn8%3d > > > > SHA512: > > > a764b6c72733c1198cc08149ecde9640de6d8886c3aedef7766c57e3198856783203c863b6dd0366c539e28cc09a6612fa76f4a0ac9074a884ffddcb109f39f3 > > > > The package was published from its corresponding git tag: > > cordova-lib: serve-0.1.3 (da2a8f39be) > > > > It has been published to npm with an 'rc' tag, so you can test it as > > follows: > > > > 1. Test its usage by the browser platform: > > > > * Clone cordova-browser locally > > * Run 'npm install' in the local cordova-browser directory > > * Run 'npm install cordova-serve@rc' in the local cordova-browser > > directory > > * Add the browser platform to a Cordova project using 'cordova platform > > add <path to local cordova-browser directory>' > > * Try 'cordova run browser' - it should work as expected, and you can > > confirm you are using 0.1.3 by checking that the console output includes > > color. > > > > 2. Test its usage by the 'cordova serve' command: > > > > * Set up a local cordova-lib clone and follow the steps so Cordova > > commands use that. > > * Run 'npm install cordova-serve@rc' in cordova-lib/cordova-lib > > * In a Cordova project directory, run 'cordova serve' > > * In a browser, navigate to the URL output by 'cordova serve' (typically > > 'http://localhost:8000'). > > * Click on one of the platform links - it should work as expected, and > you > > can confirm you are using 0.1.3 by checking that the console output > > includes color. > > > > Upon a successful vote I will upload the archive to dist/, tag it > 'latest' > > on NPM, and post the blog post. > > > > Voting guidelines: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.md&data=01%7c01%7cv-segreb%40microsoft.com%7c6d5b2849a8814248ccb308d2ac873ef4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9YRRsLvSDuGtDWwSjku8rb5JN2oz1CQW%2fW%2b1aKRbg1o%3d > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran 'coho audit-license-headers'. > > * Ran 'coho check-license' to ensure all dependencies and > sub-dependencies > > have Apache-compatible licenses. > > * Tested 'cordova run browser' and 'cordova serve' with a sample app. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
