Hey Steve - you mention version bumps for lib, cli and plugman, but that doesn't seem to be what's in dist/dev... There we have lib 5.3.0, cli 5.3.0 and plugman 1.01, but in the vote email you refer to lib 5.3.1, cli 5.3.1 and plugman 1.0.2. Did you miss updating dist/dev?
-----Original Message----- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Saturday, August 29, 2015 10:11 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools Release? Ended up making a mistake with lib which made me have to bump patch versions for lib, cli, and plugman. ugh. Vote is up. On Fri, Aug 28, 2015 at 11:18 AM, Steven Gill <stevengil...@gmail.com> wrote: > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9574&data=01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7c7c548018227b4e339f2008d2b0066f52%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uXAIHKcK0orjQpH5%2bt9Nnwb3XQWuAFVnqgKme8mJ5uQ%3d > > On Thu, Aug 27, 2015 at 11:53 PM, Nikhil Khandelwal < > nikhi...@microsoft.com> wrote: > >> I really just meant minor version bump instead of major. Sorry for the >> mix-up in terminology. >> >> -Nikhil >> >> -----Original Message----- >> From: Carlos Santana [mailto:csantan...@gmail.com] >> Sent: Thursday, August 27, 2015 11:07 PM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] Tools Release? >> >> That was my thinking no API breakage no major bump. >> >> Feature added minor bump >> >> - Carlos >> Sent from my iPhone >> >> > On Aug 28, 2015, at 1:47 AM, Steven Gill <stevengil...@gmail.com> >> wrote: >> > >> > It is interesting. Adding a new platform could be consideration for a >> > major or minor. The platform (OSX) is having a major jump. >> > >> > According to semver, a major would be making a incompatible api change >> > and a minor would be adding functionality in a backwards-compatible >> manner. >> > >> > We don't break anything by adding osx, so I'm leaning toward minor. >> > >> > -Steve >> > >> > On Thu, Aug 27, 2015 at 10:37 PM, Carlos Santana >> > <csantan...@gmail.com> >> > wrote: >> > >> >> +1 minor release bump not major >> >> >> >> - Carlos >> >> Sent from my iPhone >> >> >> >>> On Aug 27, 2015, at 11:45 PM, Nikhil Khandelwal >> >>> <nikhi...@microsoft.com> >> >> wrote: >> >>> >> >>> Also, there has been a browser release that we need to pin. >> >>> >> >>> -Nikhil >> >>> >> >>> -----Original Message----- >> >>> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] >> >>> Sent: Wednesday, August 26, 2015 6:21 PM >> >>> To: dev@cordova.apache.org >> >>> Subject: RE: [DISCUSS] Tools Release? >> >>> >> >>> +1. Not sure if it will be a patch release as it does ship new >> >>> +platforms >> >> along with it and it could be considered a major bump because of that. >> >>> >> >>> -Nikhil >> >>> >> >>> -----Original Message----- >> >>> From: Jesse [mailto:purplecabb...@gmail.com] >> >>> Sent: Wednesday, August 26, 2015 6:17 PM >> >>> To: dev@cordova.apache.org >> >>> Subject: Re: [DISCUSS] Tools Release? >> >>> >> >>> +1 >> >>> >> >>> >> >>> >> >>>> On Aug 26, 2015, at 6:14 PM, Carlos Santana <csantan...@gmail.com> >> >> wrote: >> >>>> >> >>>> Yep makes sense to cut a release before that PR hits master >> >>>>> On Wed, Aug 26, 2015 at 9:11 PM Carlos Santana >> >>>>> <csantan...@gmail.com> >> >> wrote: >> >>>>> >> >>>>> +1 >> >>>>> On Wed, Aug 26, 2015 at 8:47 PM Steven Gill >> >>>>> <stevengil...@gmail.com> >> >>>>> wrote: >> >>>>> >> >>>>>> How do people feel about a patch tools release including the >> >>>>>> recently released platforms (windows, browser) + early support >> >>>>>> for osx + updated cordova-serve. >> >>>>>> >> >>>>>> It would be nice to get this out before we add the new platform >> >>>>>> api polyfill PR which is slated to get merged end of this week. >> >>>>>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f >> >>>>>> git >> >>>>>> hub.com%2fapache%2fcordova-lib%2fpull%2f282&data=01%7c01%7cnikhil >> >>>>>> kh% >> >>>>>> 40microsoft.com%7cd6166af76ee448279b7808d2ae7d429b%7c72f988bf86f1 >> >>>>>> 41a >> >>>>>> f91ab2d7cd011db47%7c1&sdata=o4lRdDOed%2fvW6ZhlIidmAsdT2OSAwsoQ0Nw >> >>>>>> rMI >> >>>>>> 4nTU8%3d >> >>> >> >>> -------------------------------------------------------------------- >> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >>> For additional commands, e-mail: dev-h...@cordova.apache.org >> >>> >> >>> >> >>> -------------------------------------------------------------------- >> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >>> For additional commands, e-mail: dev-h...@cordova.apache.org >> >>> >> >>> >> >>> -------------------------------------------------------------------- >> >>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >>> For additional commands, e-mail: dev-h...@cordova.apache.org >> >>> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> >
