On Thu, Sep 3, 2015 at 8:07 AM Karen Tran <ktop...@gmail.com> wrote: > Hi Joe, > > I tested your patch and it works for the most part using mobilespec's > manual test for contacts. I do see the prompt for permissions contacts, but > not explicitly to read or write contacts like you mentioned. > > I don't either, even though I'm explicitly promoting for the permission. Also, I found that if you prompt for READ permissions, you get both READ and WRITE.
> One thing that doesn't work is if you click "Deny" permission, the app > crashes. I don't think we'd want that to happen, so we'll have to handle > that case. > It should work now. I forgot to return out of the method once the permission is denied. > > And as for the contact autotests, they're a bit finicky now with a couple > of failures. > Contacts has always been finicky, and needs a full re-write. I wasn't intending to fully fix this plugin (because of time), just get the permissions working because it's the low hanging fruit. Any change to the flow of the tests will break the tests because of concurrency issues with the Android Contacts API. I also have the Camera using the plugin, since we rely on external storage for determining whether we're going to produce duplicates. https://github.com/infil00p/cordova-plugin-camera/tree/smores > On Tue, Sep 1, 2015 at 9:39 AM, Carlos Santana <csantan...@gmail.com> > wrote: > > > Joe I understand the feeling. One part of me saying that we should name > the > > version 4.2 since there are no API changes. > > But my other part says that if developer's ignore because is 4.x stuff > will > > break in new major release of Android M (23) > > > > I would say that also agree that best option is to name is > > cordova-android@5 > > , then is clear to developers that they can use targetsdk=23 and also new > > major versions for the affected plugins that need updates to support > > targetsdk=23 > > > > But as you can see this is less important that getting the plugins to > work > > correctly with permissions :-) > > > > > > > > On Tue, Sep 1, 2015 at 12:03 AM Joe Bowser <bows...@gmail.com> wrote: > > > > > BTW: I got Contacts somewhat working with Marshmellow. It's still got > > the > > > same crappy concurrency bugs that it always has, and I am not sure how > to > > > resolve those without re-writing the damn thing, but the purpose of > this > > is > > > to figure out how to get permissions to work, and I have something that > > > works. > > > > > > https://github.com/infil00p/cordova-plugin-contacts/tree/smores > > > > > > This works with the latest smores tree of Cordova Android, and I tested > > it > > > on Lollipop and Marshmellow. I'm going to move on to some of the other > > > plugins to get them ready for Marshmellow, but it'd be good to have > > people > > > look these over. > > > > > > I did find a nasty security bug with this, though. If you request one > > > permission out of the permission group, you get all the permissions. > So, > > > anything that can read contacts can magically write contacts even if > you > > > don't request that permission explicitly. I think this is a serious > bug, > > > and I'm going to dig tomorrow to see if someone already reported it. > > > > > > On Mon, Aug 31, 2015 at 11:35 AM Joe Bowser <bows...@gmail.com> wrote: > > > > > > > Hey > > > > > > > > So, I created a new topic branch of my github with the new changes as > > > > suggested earlier. > > > > > > > > https://github.com/infil00p/cordova-android/tree/smores > > > > > > > > The thing we have to make sure works is if the user turns off the > > > > permissions on Marshmellow. Right now if the permissions are off, > > > > everything crashes and dies, so we're going to issue a 5.0 because > > > plugins > > > > will have to have this code to work on the latest version of Android. > > > It's > > > > not a API change, since we're adding it, but I feel that it's > important > > > > enough that we should bump the major version anyway. > > > > > > > > Can we PLEASE not have any other features creep into 5.0? If we need > > > > additional features, we can do a 6.0. I'm not against bumping major > > > > versions as long as we get into a trend of not breaking shit like we > > did > > > in > > > > the bump from 3.7 to 4.0. > > > > > > > > Also, we're going to deprecate 3.7, is there any major third-party > > > plugins > > > > that still don't work with 4.0.x that we should be aware of? Do we > > have > > > > people to cover the docs on that. > > > > > > > > Thoughts? > > > > > > > > Joe > > > > > > > > > > > > > > > > > >
