Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/121#discussion_r39069953
--- Diff: spec/unit/deployment.spec.js ---
@@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file
system as expected.', fu
describe('Windows 8.1 deployment interacts with the file system as
expected.', function() {
function runMock(cmd, args, cwd) {
- expect(cmd).toBe('c:\\Program Files (x86)\\Microsoft SDKs\\Windows
Phone\\v8.1\\Tools\\AppDeploy\\AppDeployCmd.exe');
+ expect(cmd).toBe(path.join('c:', 'Program Files (x86)', 'Microsoft
SDKs', 'Windows Phone', 'v8.1', 'Tools', 'AppDeploy', 'AppDeployCmd.exe'));
--- End diff --
@purplecabbage it looks like it doesn't work.
here is a Travis build for my repo with these changes:
https://travis-ci.org/alsorokin/cordova-windows/builds/79511398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
