As requested, here's the pull request for Cordova-Android. This should still work with the other smores plugins.
https://github.com/apache/cordova-android/pull/220 On Thu, Sep 24, 2015 at 2:51 PM, Joe Bowser <[email protected]> wrote: > After looking at the failure of what happened on 5.0.x, I'm just going to > delete it, because rebasing master on a topic branch is a terribly stupid > idea, and that's exactly what happened with that. I'm going to try and > make the changes prettier, and hopefully they'll still work. > > On Thu, Sep 24, 2015 at 2:35 PM, Carlos Santana <[email protected]> > wrote: > >> +1 on major version bump for plugins. >> >> The API signature didn't change but behavior and support did. >> >> - Carlos >> Sent from my iPhone >> >> > On Sep 24, 2015, at 5:31 PM, Joe Bowser <[email protected]> wrote: >> > >> > The 5.0 branch already has all the commits from the topic branch on >> github. >> > >> > On Thu, Sep 24, 2015 at 2:21 PM, Nikhil Khandelwal < >> [email protected]> >> > wrote: >> > >> >> +1 to major version rev. for plugins. It also is a signal these plugins >> >> will not work with any previous version of cordova. >> >> >> >> For reviewing changes, can you submit a PR perhaps from your topic >> branch >> >> to apache/cordova-android 5.x-dev branch? It's hard to review and >> comment >> >> on branch diffs - PRs allow for easy commenting and discussions. >> >> >> >> Thanks, >> >> Nikhil >> >> >> >> >> >> -----Original Message----- >> >> From: Joe Bowser [mailto:[email protected]] >> >> Sent: Thursday, September 24, 2015 1:36 PM >> >> To: dev <[email protected]> >> >> Subject: [Android] XDA is reporting that Marshmallow is out October >> 5th on >> >> TELUS >> >> >> >> Hey >> >> >> >> So, this is really weird. TELUS, just leaked that the OTA for the >> Nexus 5 >> >> and Nexus 6 is Oct 5. >> >> >> >> >> >> >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.xda-developers.com%2fxda-external-link%2ftelus-says-android-6-0-ota-update-starts-on-october-5th%2f&data=01%7c01%7cnikhilkh%40microsoft.com%7c0496829a7a764d2da4ee08d2c51fc129%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Isrv93diSPs28%2bh3arfZT6L2%2f4fjWF9X3PFM5qnsBoc%3d >> >> >> >> I don't like to rush things, but if people could review all the Smores >> >> changes while I finish up File before I do a release, that'd be >> awesome. >> >> I've already contacted Ninging Hu on the Crosswalk team about the >> upcoming >> >> Cordova release and Marshmallow, and we should be hearing more about >> that >> >> soon. Once I go through the File plugin we should be good for a >> >> preliminary run. >> >> >> >> I MIGHT write a utility method for plugins, because there is a lot of >> >> possible code repetition, but other than that, I think we're mostly >> good to >> >> go. >> >> >> >> For the plugins, I think the plugins affected by the permissions >> changes >> >> should get a major version update. Not because there's an API change, >> but >> >> because there's a slight behaviour change. Developers who are >> unfamiliar >> >> with Marshmallow who are using the plugins may be wondering why we're >> >> showing the prompts, and we should bump the majors just so that we can >> make >> >> sure they understand that Marshmallow is a big deal, despite how >> Google is >> >> underplaying it. >> >> >> >> What do people think? >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >
