Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-ios/pull/170#issuecomment-145299566
  
    I did some investigation today, I found the reason why putting 
    CLANG_ENABLE_MODULES = NO
    in build.xcconfig doesn't get reflected, is because build.xcconfig is for 
Project, not the Target, the Project file is set to Yes, and Project file has 
higher precedence than Project xcconfig
    
    For the variable assingment to be able to work it needs to be set in 
Target's release/build or extras xcconfig
    
    There is another value that also fixes our problem with a framework 
referring to a non-module header/class from CordovaLib
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    
    From looking at all levels in XCode, it looks like the iOS Platform default 
is:
    CLANG_ENABLE_MODULES = NO and 
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO
    But XCode 7 when it creates a new projects, overwrites the default of one 
of them to CLANG_ENABLE_MODULES = YES
    
    It might be safer to set 
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    which I think is more closer to the compile error that we are getting, and 
maybe has less side effects.
    
    By Google Power I discover this page, explains variable assignment 
precedence:
    http://pewpewthespells.com/blog/xcconfig_guide.html
    
    What you all think?
    And what would be the best to assign it? Project (build.xcconfig) or Target 
(build-debug.xcconfig and build-release.xcconfig)
    We could use extras but I would like to leave extra empty for the 
developer/user to overwrite values from Target and Project xcconfig 
programmatically
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to