Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/106#discussion_r42734873
--- Diff: src/wp/FileTransfer.cs ---
@@ -775,11 +775,8 @@ private void downloadCallback(IAsyncResult
asynchronousResult)
}
catch (WebException webex)
{
- // TODO: probably need better work here to properly
respond with all http status codes back to JS
- // Right now am jumping through hoops just to detect 404.
HttpWebResponse response = (HttpWebResponse)webex.Response;
- if ((webex.Status == WebExceptionStatus.ProtocolError &&
response.StatusCode == HttpStatusCode.NotFound)
- || webex.Status == WebExceptionStatus.UnknownError)
+ if ((webex.Status == WebExceptionStatus.ProtocolError) ||
(webex.Status == WebExceptionStatus.UnknownError))
--- End diff --
Please remove excess brackets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
