I don't think we thought of symlinks in this usecase. Probably worth adding in code that checks for symlinks before the copy. I don't see us removing this copy as the cordova scripts (build, run, install, etc) require those modules.
On Tue, Oct 27, 2015 at 9:24 PM, Dmitry Blotsky <dblot...@microsoft.com> wrote: > Ping. Anyone have any information on this? Is it safe to "cp -r” a > node_modules directory? > > Kindly, > Dmitry > > > On Oct 26, 2015, at 3:06 PM, Dmitry Blotsky <dblot...@microsoft.com> > wrote: > > > > Hey folks, > > > > I’ve come across a bug with symlinks and platform installation recently. > The point of interest is this line: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-ios%2fblob%2f4039aeb6f87c6803df5814b8cdefb8c2058504a0%2fbin%2flib%2fcreate.js%23L93.&data=01%7c01%7cdblotsky%40microsoft.com%7c2b31253a23cc4d165ed808d2de51c9ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cyXGPBQPr9v46gc6DMDeC9zZkzda8bSCIoinEyAmKrs%3d > > > > Is copying node_modules a safe operation? In my case there was a > relative symlink inside it when it was copied and as a result some > dependencies broke. The symlink was created by a previous invocation of > “npm link”. > > > > Kindly, > > Dmitry > >
