choo choo !! On Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote:
> I vote +1 > > * Ran coho verify-archive successfully > * Created blank application using cordova-app-hello-world@3.10.0, build > and ran successfully > > - > Best regards, Vladimir > > -----Original Message----- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Thursday, October 29, 2015 5:20 AM > To: dev@cordova.apache.org > Subject: Re: [Vote] 3.10.0 Cordova App Hello World Release > > +1 > Review the new commits for release > Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz > Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) > Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 > --dest test-hello/ and compare with dist Created test app with new > app-hello-world > > minor comments, nothing to stop the vote: > - CB-9712 I think it is npm 3, instead of node 3.3.3 > - CB-8896 using spec attribute instead of version attribute for whitelist > plugin in config.xml, I was not able to find were do we document the > <plugin> element for config.xml [1] > > [1]: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-docs%2fblob%2fmaster%2fwww%2fdocs%2fen%2fedge%2fconfig_ref%2findex.md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oPPRggL3%2bg3RSHgIUhcCdJb02FNg1CA4LPSh8ZTekQ4%3d > > On Mon, Oct 26, 2015 at 8:24 PM Steven Gill <stevengil...@gmail.com> > wrote: > > > Please review and vote on this 3.10.0 Cordova App Hello World Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > > s.apache.org%2fjira%2fbrowse%2fCB-9870&data=01%7c01%7cv-vlkoti%40064d. > > mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141a > > f91ab2d7cd011db47%7c1&sdata=ENB0p90lCZ1zbkOoCyTMZNAPDjT752qlJCRA9fcNtD > > g%3d > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.10.0 (64d5c71f05) > > > > Upon a successful vote I will upload the archive to dist/ and publish > > it to NPM. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting. > > md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53 > > 312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=EUgWsABn > > hfoIb5nxx6uQLp%2faefXOXrcIFfhknXjuCwE%3d > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
