GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/113
CB-7006 Empty file is created on file transfer if server response is 304
Adds a corresponding test.
Fixes the Windows proxy to not to delete the file in case of 304.
As a side effect the new code will not delete a cached file (previously
downloaded f.e.) in case of a download error.
The test is passing on Android and Windows (with this modification) and
fails on iOS as code 200 comes for the second request disregarding the
`If-Modified-Since` header, as soon as we get code 200 in the first request
(the file is being cached by the iOS proxy somewhere).
@shazron, could you please point to where to look at in the iOS
implementation for this caching?
[Jira issue](https://issues.apache.org/jira/browse/CB-7006)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer
CB-7006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit a85d54da8db9b52bc55160b933640b05383464e1
Author: daserge <v-ses...@microsoft.com>
Date: 2015-11-11T11:06:23Z
CB-7006 Empty file is created on file transfer if server response is 304
Adds a corresponding test.
Fixes the Windows proxy to not to delete the file in case of 304.
As a side effect the new code will not delete a cached file in case of a
download error.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
