Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161140513 Please note that the tests do test for the bug in CB-8115, and _don't catch it_. Here is an example: https://github.com/MSOpenTech/cordova-plugin-contacts/blob/CB-8115/tests/tests.js#L359. Please also fix all occurrences of that incorrect check. It might help to write a helper function.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org