GitHub user tualatrix opened a pull request:
https://github.com/apache/cordova-ios/pull/187
Use "cdv_" prefixed scrollView for UIView to avoid conflicts
After upgrading cordova-ios from 3.9.x to 4.0.x, I found there's a conflict
for my custom UIView and cordova. It is caused by the category in Cordova,
CDVPlugin.h:
```
@interface UIView (org_apache_cordova_UIView_Extension)
@property (nonatomic, weak) UIScrollView* srollView;
@end
```
As an extension that used internally in Cordova, it should not use a common
name of "scrollView". If developer's project have a custom UIView that has a
scrollView, the project will be broken.
So I did this pull request that rename this "scrollView" to "cdv_srollView".
Please take a review, thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tualatrix/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit b589e755ec340e4bdd92fc679613a537ca3ec88a
Author: Tualatrix Chou <tualat...@gmail.com>
Date: 2015-12-24T07:11:35Z
Use "cdv_" prefixed scrollView for UIView to avoid conflicts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
