Github user jcesarmobile commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450641
  
    --- Diff: src/ios/CDVSplashScreen.m ---
    @@ -187,7 +187,35 @@ - 
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation delegate:(i
         {
             imageName = @"Default";
         }
    -    
    +
    +    // Add Asset Catalog specific prefixes
    +    if ([imageName isEqual:@"LaunchImage"])
    +    {
    +        if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone)
    --- End diff --
    
    you have the device, so you can do a if (device.iPhone), and you have 
device.iPhone5, device.iPhone6, device.iPhone6Plus and device.iPad available 
too, so you can use them instead of checking the size again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to