Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/359#discussion_r48599256
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, 
project_dir, plugins_dir,
         events.emit('verbose', 'Install start for "' + pluginInfo.id + '" on ' 
+ platform + '.');
     
         options.variables = filtered_variables;
    -    // Set up platform to install asset files/js modules to 
<platform>/platform_www dir
    -    // instead of <platform>/www. This is required since on each prepare 
platform's www dir is changed
    -    // and files from 'platform_www' merged into 'www'. Thus we need to 
persist these
    -    // files platform_www directory, so they'll be applied to www on each 
prepare.
    -    options.usePlatformWww = true;
    +    if (!('www_dir' in options) || options.www_dir === undefined) {
    --- End diff --
    
    There is some inconsistency in how this option should be specified: the 
[plugman's 
README](https://github.com/apache/cordova-plugman/blob/master/README.md#plugin-management)
 states that there is `--www` option for plugman cli, [comments in cordova-lib 
code](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L68)
 metntion `www_dir` option, but there is no code, reponsible for conversion 
`--www` -> `www_dir`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to