+1

Created a project, and did a brief code review

Saw a non-blocker issue:

*Error: icon does not exist:
/Tests/TestUbuntu/platforms/ubuntu/www/www/img/logo.png*


@purplecabbage
risingj.com

On Mon, Jan 4, 2016 at 1:02 AM, David Barth <david.ba...@canonical.com>
wrote:

> Thanks Shazron.
>
> And hi guys! :) I would like to resume the voting process on this thread.
>
> Thanks
>
>
> On Tue, Dec 22, 2015 at 2:04 AM, Shazron <shaz...@gmail.com> wrote:
>
> > +1
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * added platform and built using master versions of the CLI and
> > cordova-lib (on OS X and Ubuntu 15)
> >
> >
> > On Mon, Dec 21, 2015 at 3:33 AM, David Barth <david.ba...@canonical.com>
> > wrote:
> > > Please review and vote on this 4.3.2 Android Release
> > > by replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-10210
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-10210/
> > >
> > > The package was published from its corresponding git tag:
> > > cordova-ubuntu: 4.3.2 (2e019a849a)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
> > https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
> > > .git#4.3.2
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> to
> > > npm, and post the blog post.
> > >
> > > Voting guidelines:
> > >
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and subdependencies
> > > have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > > * Ran mobile-spec
> > > * Created and ran hello world project on device
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Reply via email to