Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/72#discussion_r50489033
  
    --- Diff: medic/medic-run.js ---
    @@ -324,23 +349,8 @@ function main() {
             util.fatal("app " + appPath + " does not exist");
         }
     
    -    util.medicLog("checking if " + couchdbURI + " is up");
    -
    -    // check if results server is up
    -    request({
    -        uri:     couchdbURI,
    -        method:  "GET",
    -        timeout: SERVER_RESPONSE_TIMEOUT
    -    },
    -    function (error, response, body) {
    -
    -        // bail if the results server is down
    -        if (error || response.statusCode !== 200) {
    -            util.fatal("it's not up, so test run can't be monitored");
    -            process.exit(1);
    -        } else {
    -            util.medicLog("it's up");
    -        }
    +    onConnect(couchdbURI, 1, function(){
    --- End diff --
    
    If possible, maybe also change the signature of the retry function to hide 
the `1` from the caller, so that it only takes a URI and a callback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to