GitHub user jclalala opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/78

    CB-10476 - fix problem where callbacks were not invoked on android du…

    seems like the faulty code was added back in this commit:
    
    
https://github.com/apache/cordova-plugin-media/commit/c4547c94c5850c619b0936551ec1180f4465a95b#diff-ea1d1dcd03fa62ee9f2774edbf524977
    
    line 121.
    
    problem happens when messageChannel is reset with callbackContext every 
call... removing this will fix the problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jclalala/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
    
----
commit 8801f3943c557a82747781696f1e20978b8184e0
Author: Jeffrey Chang <jeff...@stiteq.com>
Date:   2016-01-29T13:13:59Z

    CB-10476 - fix problem where callbacks were not invoked on android due to 
messageChannel being overridden by callbackContext in every execut() call

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to