Hi Sean, such discussion should happen in [Discuss] thread, before vote is started. CB-7786 introduces new functionality so this should be in minor or major release anyway. I've reviewed your PR and it looks good, I'll merge it later today.
Thx! -Sergey -----Original Message----- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, February 3, 2016 5:44 AM To: dev@cordova.apache.org Subject: Re: [VOTE] InAppBrowser Plugin Release Hey Sean, We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those. According to ASF policies, only PMC members can vote. I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it reviewed and in the next inappbrowser plugin release. We can do another inappbrowser release shortly after. Cheers, -Steve On Tue, Feb 2, 2016 at 6:39 PM, Sean Kelly <h...@seank.com> wrote: > I'd vote no. I'd really like to see CB-7786 get in before the next release. > > SeanK > > On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > Please review and vote on the InAppBrowser plugin release by > > replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss > > ues.apache.org%2fjira%2fbrowse%2fCB-10505&data=01%7c01%7cv-segreb%40 > > microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c72f988bf86f141af9 > > 1ab2d7cd011db47%7c1&sdata=UhXz%2bhfLfjU0cK16GNLrW0Bmmeqi1hzwEET2zeae > > mQU%3d > > > > The plugin has been published to dist/dev: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdis > > t.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10505%2f&data=01%7c > > 01%7cv-segreb%40microsoft.com%7c594a03e53e384d3cfc7008d32c43fc36%7c7 > > 2f988bf86f141af91ab2d7cd011db47%7c1&sdata=bDfFos9mxYdJZ27CMfUl2sNMH7 > > G2X%2fBaI4GbfmgUVQ8%3d > > > > The package were published from their corresponding git tag: > > cordova-plugin-inappbrowser: 1.2.1 (df94a6c157) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them > to > > the Plugins Registry, and post the corresponding blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Run auto tests for iOS, Android and Windows > > > > -Sergey > > > > -------------------------------------------------------------------- > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
