Github user vladimir-kotikov commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-file-transfer/pull/127#discussion_r54331337
  
    --- Diff: .jscsrc ---
    @@ -1,7 +1,7 @@
     {
         "disallowMixedSpacesAndTabs": true,
         "disallowTrailingWhitespace": true,
    -    "validateLineBreaks": "CRLF",
    +    "validateLineBreaks": "LF",
    --- End diff --
    
    Should we do this validation? AFAIK we had some promlems with line endings 
only in executable scripts, so CRLF vs LF should n't be a problem for plugin 
code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to