GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/106
CB-10632: Fixing jasmine test contact removal
This is related to the flaky tests that have been failing in the
android-win CI. As the jasmine tests execute, they create contacts and
occasionally fail to remove them. When that happens, the created contacts will
never be removed and all of the tests that depend on those contacts not
existing will fail until someone manually deletes the contacts on the emulator.
This PR does not fix the test flakiness issue, but does fix the issue of the
tests being permanently broken by a single failure. It also makes it so that
the removal failures will actually be reported by jasmine where they were not
previously so that we can hopefully pinpoint the real issue and fix the flaky
test in a later PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-10632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 85a16a8bdb82098891dfe8e13996aebf44f72d77
Author: riknoll <richard.b.kn...@gmail.com>
Date: 2016-03-03T20:13:29Z
CB-10632: Fixing jasmine test contact removal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
