I already said on the jira issue that I preffer not to add this. And cordova iOS 4.X.X breaks on iOS 6 and older, so it's a matter of time that you will have to update to cordova iOS 4 and you won't be able to support that versions.
But the truth is the PR is very simple and won't make any harm to add it. It will need the changes I commented on the issue. 2016-03-08 20:01 GMT+01:00 Steven Gill <stevengil...@gmail.com>: > Personally, I'm not a fan of adding/keeping legacy code for platforms we > don't support. > > On Tue, Mar 8, 2016 at 9:09 AM, Thomas Allen <tho...@agilelaw.com> wrote: > > > I opened ticket CB-10631 regarding the "Device" plugin that didn't work > > when I built my app for iOS 5.1.1. I was asked by user jcesarmobile to > send > > an email to discuss. > > > > https://issues.apache.org/jira/browse/CB-10631 > > > > Basically I submitted a patch to allow the plugin to work with iOS 5.1.1. > > You can see in my description what I've done and how it works using > Cordova > > 5.4.1. > > > > I'm not suggesting the Cordova project support iOS 5.1.1, but the > question > > is whether the project should explicitly reject code that is used to > make a > > plugin backward compatible. > > > > I have an app on the app store that uses Cordova 5.4.1, compiled using > > Xcode 6.4, with the patch that I submitted for this plugin, and it works > > fine on iPad 1 on 5.1.1, iPad 2 on iOS 7 and iPad Air on iOS 8. > > > > > > *Thomas Allen* > > ceo | agilelaw > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Fagilelaw.com%2F&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > | address > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Fgoo.gl%2Fmaps%2FUzxyg&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > > > o 512.348.6525 x101 > > m 512.587.3692 > > > > facebook <http://www.facebook.com/agilelaw> | twitter > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Ftwitter.com%2F%23!%2Fagilelaw&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > | linkedin > > < > > > http://t.sidekickopen41.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XYg63BfN4VQZcG02BF-CKW7dKLV856dVZ5f7rsvGK02?t=http%3A%2F%2Flinkedin.com%2Fcompany%2Fagilelaw&si=6504882442338304&pi=0c8e6479-f1c1-4706-9027-f239475c05c9 > > > > > >
