Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55578144
  
    --- Diff: src/ios/CDVSound.m ---
    @@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command
         NSString* mediaId = [command argumentAtIndex:0];
         NSString* resourcePath = [command argumentAtIndex:1];
     
    -    CDVAudioFile* audioFile = [self audioFileForResource:resourcePath 
withId:mediaId doValidation:NO forRecording:NO];
    +    CDVAudioFile* audioFile = [self audioFileForResource:resourcePath 
withId:mediaId doValidation:YES forRecording:NO];
    --- End diff --
    
    What's the reason we aren't doing validation anymore ? This leads to this 
code being skipped: 
https://github.com/gaelenh/cordova-plugin-media/blob/ios-no-audio-playback/src/ios/CDVSound.m#L160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to