Github user daserge commented on the pull request:

    https://github.com/apache/cordova-android/pull/273#issuecomment-195769121
  
    Tested - master version works with both `--buildConfig` and `-- --keystore`.
    With this PR the CLI outputs the following:
    ```
    BUILD SUCCESSFUL
    
    Total time: 18.57 secs
    Built the following apk(s):
    
    Error: Could not find apk architecture: x86 build-type: release
    ```
    which is IMO misleading as `android-release-unsigned.apk` is actually built 
(and can be signed manually). 
    Probably we can improve [this 
message](https://github.com/apache/cordova-android/blob/82582e5a5bb3b7472d51812d902b5074227aa41b/bin/templates/cordova/lib/build.js#L235)
 instead to state about the need of apk signing directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to