Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/276#discussion_r56369539
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget,
buildResults) {
if (err) reject(new CordovaError('Error executing
"' + command + '": ' + stderr));
// adb does not return an error code even if
installation fails. Instead it puts a specific
// message to stdout, so we have to use RegExp
matching to detect installation failure.
- else if (/Failure/.test(stdout)) reject(new
CordovaError('Failed to install apk to emulator: ' + stdout));
- else resolve(stdout);
+ else if (/Failure/.test(stdout)) {
+ if
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+ stdout += 'Sign the build using \'--
--keystore\' or \'--buildConfig\'' +
+ ' or sign and deploy the unsigned apk
manually using Android tools.';
+ }
+
+ reject(new CordovaError('Failed to install apk
to emulator: ' + stdout));
+ } else resolve(stdout);
--- End diff --
Does it make sense to de-duplicate this error string since it also occurs
in `Adb.js`, or would that be too cumbersome?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
