The malformed package published didn't have any functional impact, just extra files, So I don't see the need to do a release just for that, But I found a critical issue as I kept testing 6.1.0 more in depth
Any way we should follow process as normal, do a CLI bug/patch 6.1.1 and have a [DISCUSS] on what should be in it like any bugs already fix in master and anything else that is almost ready/fix On Fri, Mar 25, 2016 at 10:18 AM Vladimir Kotikov (Akvelon) < [email protected]> wrote: > Hmm.. I thought the idea of 6.1.1 was to fix malformed package contents on > NPM and upload a correct package. > - > Best regards, Vladimir > > -----Original Message----- > From: Carlos Santana [mailto:[email protected]] > Sent: Friday, March 25, 2016 4:18 PM > To: [email protected] > Subject: Re: 6.1.0 (cordova-lib@undefined) ? > > Vladimir, every Vote needs a new email thread "[DISCUSS]" so we can > discuss what would be in the new release > > I found a bad regression in 6.1.0, I think we should fix it and release > the fix with 6.1.1 Can you take a look at the JIRA and help fix > > As for the removing the cordova-common, let's do that in next patch > release maybe a 6.1.2, right now at least is critical for my work to get a > working 6.1.1, people are already using 6.1.0 and broke > > [1]: https://issues.apache.org/jira/browse/CB-10961 > > > On Fri, Mar 25, 2016 at 8:58 AM Vladimir Kotikov (Akvelon) < > [email protected]> wrote: > > > I've started a vote thread. Voters are welcome :) > > > > Also I've notices that we bundle `cordova-common` into cordova-lib > > package. This is probably just a legacy of the time when > > cordova-common hadn't been released yet. > > However this is not a problem anymore so we should remove this > > `bundleDependencies` section? > > > > - > > Best regards, Vladimir > > > > -----Original Message----- > > From: Vladimir Kotikov (Akvelon) [mailto:[email protected]] > > Sent: Friday, March 25, 2016 9:40 AM > > To: [email protected] > > Subject: RE: 6.1.0 (cordova-lib@undefined) ? > > > > I'll take care of it > > > > - > > Best regards, Vladimir > > > > -----Original Message----- > > From: Steven Gill [mailto:[email protected]] > > Sent: Thursday, March 24, 2016 7:11 PM > > To: [email protected] > > Subject: Re: 6.1.0 (cordova-lib@undefined) ? > > > > Shoot! So I am checking this out at the airport. > > > > So usually cordova-lib version is not supposed to show. It is for > > development only and I find it very useful. > > > > Looks like I made a mistake when publishing cordova-lib :( I was > > doing some tests to see what modules were being picked up when running > npm pack. > > I ended up not deleting those test files from cordova-lib directory > > and they got included. I published the tag from the repo when I should > > have npm published the tgz. My bad guys. It needs to get repackaged > > and published, but with npm, only way to do that is to bump version. > > So 6.1.1. Sucks that we have to vote for a repackage with no changes. > > > > Sorry. Can someone do this? > > > > -Steve > > On Mar 24, 2016 8:49 AM, "Carlos Santana" <[email protected]> wrote: > > > > > Why do we need to print the version of cordova-lib inside CLI ? > > > > > > $ cordova -v > > > 6.1.0 (cordova-lib@undefined) > > > > > > I opened a JIRA [1] > > > > > > Do we want to remove the extra info of cordova-lib and only print > > > the CLI version? > > > > > > cordova-lib is a npm dependency on cordova-cli like any of the other > > > dependencies [2] > > > > > > Does someone using this extra info? > > > Do we need to provide more info or less info or provide more info > > > behind -d flag (i.e cordova -v -d)? > > > > > > [1]: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss > > > ue > > > s.apache.org%2fjira%2fbrowse%2fCB-10952&data=01%7c01%7cv-vlkoti%40mi > > > cr > > > osoft.com%7c8eae6527f8614b78403808d353ff0b68%7c72f988bf86f141af91ab2 > > > d7 > > > cd011db47%7c1&sdata=Pvc1SOKl%2fgMyUhAwUP%2fRmlZzy%2buQV5OE7tzSJWbWhr > > > M% > > > 3d > > > [2]: > > > https://github.com/apache/cordova-cli/blob/master/package.json#L31 > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
