Github user dubeejw commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57905517
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -85,12 +85,12 @@ var handlers = {
                 var src = obj.src;
                 var dest = src;
                 var type = obj.type;
    +            var targetDir = obj.targetDir || '';
     
                 if(type === 'projectReference') {
    -                project.addProjectReference(path.join(plugin.dir,src), 
getTargetConditions(obj));
    -            }
    -            else {
    -                var targetDir = obj.targetDir || '';
    +                dest = path.join('plugins', plugin.id, targetDir, src);
    +                project.addProjectReference(dest, 
getTargetConditions(obj));
    --- End diff --
    
    Making the call to addProjectReference() common.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to