Github user Panajev commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/95#issuecomment-203582719
@jcesarmobile Sorry for the early PR and for not really following all the
steps of the process in the right order :/.
**Signing**
Goff Marocchi is me (actually Goffredo Marocchi) and yes I do still need to
sign it, but I will ask James and Gabriela to sign it too.
**Multiplatform Concerns**
* The changes apply to both Android and iOS and we did pull out anything
referring to custom UI for the splashscreen when the main URL is changed. The
splashscreen being shown is always the same.
* A point could be made about the Material Design like spinner. We would
like to uniform the spinner design where it is possible and make it look more
modern, but for example on iOS 6 this is not a trivial change for a platform
which is less and less the target of developers worldwide. Also we may still
need to commit work for the Android version of the plugin for the spinner too.
* I understand your point about separating the spinner from the current
PR, possibly breaking it into plugins this very plugin would be able to
optonally use. Maybe broadcasting a message and expecting a new UI Element
back? Will address this concern.
**iPad Pro**
I will look into a JIRA ticket for it. I will look for a default image for
the cordova-ios project. We have forked it off for internal reasons so we are
using a slightly modified version of cordova-ios 3.8.0. Still, I take your
point and will try to address them.
**iOS 8 bugfixes**
I will look into a JIRA ticket for it. Should I still split it into a
different PR here or should I include both JIRA ticket numbers in the PR?
**HTML5 boilerplate license**
Sorry, cruft I forgot to delete. Will remove it.
**Clobber change**
The thought behind the clobber was to namespace the cordova plugins, like
we do for all other plugins we use internally, to a
window.nativeWrapper.<pluginName> space to avoid collisions with other
JavaScript libraries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
