Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/426#discussion_r59596872
--- Diff: cordova-lib/src/cordova/run.js ---
@@ -32,8 +32,10 @@ module.exports = function run(options) {
var hooksRunner = new HooksRunner(projectRoot);
return hooksRunner.fire('before_run', options)
.then(function() {
- // Run a prepare first, then shell out to run
- return require('./cordova').raw.prepare(options);
+ if (!options.options.noprepare) {
+ // Run a prepare first, then shell out to run
+ return require('./cordova').raw.prepare(options);
+ }
--- End diff --
Are you sure that's necessary? Any promise libraries I've used did not
require returning another promise when the then function completes
synchronously. Even for a similar case in this file, that is not done after the
if block on line 72.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
