Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/4#discussion_r59643631
  
    --- Diff: lib/ParamedicConfig.js ---
    @@ -104,4 +117,44 @@ ParamedicConfig.prototype.getTimeout = function() {
         return DEFAULT_TIMEOUT;
     };
     
    +ParamedicConfig.prototype.getLogPath = function() {
    +    return this._config.logPath;
    +};
    +
    +ParamedicConfig.prototype.setLogPath = function(logPath) {
    +    this._config.logPath = logPath;
    +};
    +
    +ParamedicConfig.prototype.getLogMins = function() {
    +    return this._config.logMins;
    +};
    +
    +ParamedicConfig.prototype.setLogMins = function(logMins) {
    +    this._config.logMins = logMins;
    +};
    +
    +ParamedicConfig.prototype.setAppName = function(appName) {
    +    this._config.appName = appName;
    +};
    +
    +ParamedicConfig.prototype.getAppName = function() {
    +    return this._config.appName;
    +};
    +
    +ParamedicConfig.prototype.setSimulatorsFolder = function(simulatorsFolder) 
{
    +    this._config.simulatorsFolder = simulatorsFolder;
    --- End diff --
    
    Consider using what we do for getting simulator logs. Ideally we should 
have one way of doing this and not configurable externally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to